Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9553 )
Change subject: Remove namespace hack in hms_client.h ...................................................................... Remove namespace hack in hms_client.h To avoid having to use the very long Apache.Hadoop.Hive namespace for all of the Thrift-generated HMS types, we aliased the namespace in hms_client.h to 'hive'. This doesn't really work well, I've seen issues in tests where for unknown reasons the hive namespace doesn't work. A better fix is to just edit hive_metastore.thrift to change the generated namespace, since it's vendored anyway. This exposed that our CMake thrift generator doesn't properly consider the input .thrift files to be a dependency of the code generation step, so I had to fix that as well to get this to compile without blowing away the build dir. Change-Id: I1b4d823a0329c63c9ce830f855c3d1021fbc08cf Reviewed-on: http://gerrit.cloudera.org:8080/9553 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M cmake_modules/FindThrift.cmake M src/kudu/hms/hive_metastore.thrift M src/kudu/hms/hms_client.h 3 files changed, 5 insertions(+), 3 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9553 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1b4d823a0329c63c9ce830f855c3d1021fbc08cf Gerrit-Change-Number: 9553 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
