Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9612 )
Change subject: KUDU-2343. java: properly reconnect to new leader master after failover ...................................................................... Patch Set 2: Code-Review+2 (3 comments) Thank you for fixing this issue. I didn't expect we had no test that would cover the situation described in KUDU-2343 http://gerrit.cloudera.org:8080/#/c/9612/2/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToClusterResponse.java File java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToClusterResponse.java: http://gerrit.cloudera.org:8080/#/c/9612/2/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToClusterResponse.java@a73 PS2, Line 73: Was this the culprit of the problem? http://gerrit.cloudera.org:8080/#/c/9612/2/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java File java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java: http://gerrit.cloudera.org:8080/#/c/9612/2/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java@72 PS2, Line 72: TODO(todd) it would make more sense to key this by IP address rather than by UUID in : * case a server actually changes address and re-registers to the cluster. Yup, that would be closer to the 'nature of the things', but I think for 1.7 the current fix is adequate enough. http://gerrit.cloudera.org:8080/#/c/9612/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java: http://gerrit.cloudera.org:8080/#/c/9612/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectionCache.java@a65 PS2, Line 65: > this old comment was just wrong. The extra 1 was from the fake master ID "" Oh, it seems I misunderstood what those entries were, indeed. I should have printed them out. -- To view, visit http://gerrit.cloudera.org:8080/9612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36f96c6712800e398ed46887d97d4b09fd993b04 Gerrit-Change-Number: 9612 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Anonymous Coward #314 Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 13 Mar 2018 23:32:42 +0000 Gerrit-HasComments: Yes
