Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9617 )
Change subject: KUDU-1704: add python client support for READ_YOUR_WRITES mode ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9617/2/python/kudu/tests/test_scanner.py File python/kudu/tests/test_scanner.py: http://gerrit.cloudera.org:8080/#/c/9617/2/python/kudu/tests/test_scanner.py@207 PS2, Line 207: scanner.set_read_mode(kudu.READ_LATEST)\ > Nit: should this use the string style instead of the enum style to match be I think it is ok, I think the idea is either style should work. -- To view, visit http://gerrit.cloudera.org:8080/9617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281a73ead2d606e698ff7f44ddb2cd1c78ffdd2a Gerrit-Change-Number: 9617 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 14 Mar 2018 04:05:06 +0000 Gerrit-HasComments: Yes