Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 )
Change subject: KUDU-2351 Add IP/port for Recv() failure ...................................................................... Patch Set 6: (3 comments) You may also want to make these changes to the TlsSocket class in tls_socket.cc, which is used instead of the normal socket for encrypted RPCs. http://gerrit.cloudera.org:8080/#/c/9818/6/src/kudu/util/net/socket-test.cc File src/kudu/util/net/socket-test.cc: http://gerrit.cloudera.org:8080/#/c/9818/6/src/kudu/util/net/socket-test.cc@46 PS6, Line 46: virtual void SetUp() OVERRIDE prefer using the C++11 style for new code here and below: void SetUp() override { http://gerrit.cloudera.org:8080/#/c/9818/6/src/kudu/util/net/socket-test.cc@48 PS6, Line 48: address.ParseString("127.0.0.1", 11010); Is this address being used anywhere? If possible avoid hard coded ports, since they make tests flaky and difficult to parallelize. http://gerrit.cloudera.org:8080/#/c/9818/6/src/kudu/util/net/socket-test.cc@95 PS6, Line 95: TEST_F(SocketTest, TestRecvReset) { gtest has a built-in feature that facilitates writing this style of test, check out https://github.com/google/googletest/blob/master/googletest/docs/AdvancedGuide.md#value-parameterized-tests and grep kudu for 'TEST_P' to find examples. -- To view, visit http://gerrit.cloudera.org:8080/9818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22436b13bb351b132e1c0b7159294dd0c980c2b3 Gerrit-Change-Number: 9818 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 27 Mar 2018 19:06:29 +0000 Gerrit-HasComments: Yes
