Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9839 )
Change subject: [java] Fix javadoc issues ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9839/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9839/2//COMMIT_MSG@15 PS2, Line 15: This is far from all of the correctness issue, but the few : that were resulting in Javadoc Gradle errors. > Can we convert these errors into precommit build failures so they're caught The actual errors will fail the build. Though there are less of them now that we disable the strict linter. http://gerrit.cloudera.org:8080/#/c/9839/2/java/gradle/compile.gradle File java/gradle/compile.gradle: http://gerrit.cloudera.org:8080/#/c/9839/2/java/gradle/compile.gradle@31 PS2, Line 31: // Disable the super-strict doclint tool in Java 8+ > Hmm, do we do this in the Maven build too? If not, why isn't it necessary? I didn't investigate why Maven wasn't outputting all the warnings on the cli output but just assumed it handled it. Since you asked I look into it and it turns out the Yetus doclet we are using is what suppresses all of the Java 8 doclint warnings. I hadn't setup the doclet in gradle yet. I will look into why the Yetus doclet suppresses them and also into adding the doclet to the gradle build. -- To view, visit http://gerrit.cloudera.org:8080/9839 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5914b416e1b084a4f50dd8ea878be2f065acbe94 Gerrit-Change-Number: 9839 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 28 Mar 2018 16:37:07 +0000 Gerrit-HasComments: Yes
