Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9840 )
Change subject: KUDU-2385: Fix typo in KinitContext::DoRenewal() ...................................................................... Patch Set 1: > Patch Set 1: > > Todd, we use this macro here: > https://github.com/apache/impala/blob/master/be/CMakeLists.txt#L349-L350 > > CHECK_LIBRARY_EXISTS("krb5" krb5_get_init_creds_opt_set_out_ccache > ${KERBEROS_LIBRARY} HAVE_KRB5_GET_INIT_CREDS_OPT_SET_OUT_CCACHE) Perhaps we can port that over into the security/CMakeLists.txt ? It desn't have to be in this same patch, just a suggestion to reduce divergence between code -- To view, visit http://gerrit.cloudera.org:8080/9840 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a22b8d41d15eb1982a3fd5b96575e28edaad31c Gerrit-Change-Number: 9840 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 28 Mar 2018 19:08:12 +0000 Gerrit-HasComments: No
