Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9852 )
Change subject: [examples] Improve the basic Java example ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9852/1/examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java File examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java: http://gerrit.cloudera.org:8080/#/c/9852/1/examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java@75 PS1, Line 75: cto.setRangePartitionColumns(rangeKeys); Now that we support hash partitioning, and we kinda think that hash partitioning is a better starting choice, perhaps we should be using hash partitioning in our simple example? http://gerrit.cloudera.org:8080/#/c/9852/1/examples/java/java-example/src/main/java/org/apache/kudu/examples/Example.java@129 PS1, Line 129: // Scan with a predicate on the 'key' column, returning the 'value' and "added" columns. maybe we can refactor out some methods from this enormous function? eg 'void exampleScan()' and 'void setupTable', etc -- To view, visit http://gerrit.cloudera.org:8080/9852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79ab5b0b2c30e8fd7c799857a0e3754b7618a580 Gerrit-Change-Number: 9852 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 30 Mar 2018 01:39:47 +0000 Gerrit-HasComments: Yes
