Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9853 )
Change subject: [examples] Improve loadgen example ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9853/2/examples/java/insert-loadgen/src/main/java/org/apache/kudu/examples/InsertLoadgen.java File examples/java/insert-loadgen/src/main/java/org/apache/kudu/examples/InsertLoadgen.java: http://gerrit.cloudera.org:8080/#/c/9853/2/examples/java/insert-loadgen/src/main/java/org/apache/kudu/examples/InsertLoadgen.java@125 PS2, Line 125: if (insertCount % 1000 == 0 && session.countPendingErrors() > 0) { Gating the flush on insertCount being a multiple of 1000 I understood, but not checking for errors. -- To view, visit http://gerrit.cloudera.org:8080/9853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc0e655f56adcedec2c3dd8a8b3c900e3b2e7803 Gerrit-Change-Number: 9853 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 02 Apr 2018 14:51:08 +0000 Gerrit-HasComments: Yes
