Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9900
to review the following change.
Change subject: WIP: fix flaky file_cache-test
......................................................................
WIP: fix flaky file_cache-test
This test became flaky after 4db748f3021711a67017fe51f30097350f343101
since that commit added a chance that a background thread opened a file
descriptor during the run of this test, which makes assertions on file
descriptor count.
This patch attempts to fix the issue by making the test only count fds
which point to files within the test dir, rather than all open fds. It
doesn't fully address the issue though due to the PeriodicOpenFdChecker.
Posting as a WIP to get feedback: would it be good to finish this or
just change the test to somehow disable the 'IsBeingDebugged' check from
opening any fds?
Another option would be to have IsBeingDebugged open a file descriptor
and reuse it without closing in between so that the code which looks at
the initial open fd count would account for it.
Change-Id: I5bd51c267fbc7dc954d593caedf8631f261909c9
---
M src/kudu/util/file_cache-test.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
3 files changed, 55 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/9900/1
--
To view, visit http://gerrit.cloudera.org:8080/9900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bd51c267fbc7dc954d593caedf8631f261909c9
Gerrit-Change-Number: 9900
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
