Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9863 )
Change subject: KUDU-2191 (8/n): Integrate HmsCatalog into CatalogManager ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/9863/6/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/9863/6/src/kudu/hms/hms_catalog.cc@440 PS6, Line 440: __builtin_unreachable(); > You could also use __builtin_unreachable() down here instead of moving this ah, that's great to know about. I'm continually annoyed by this issue. -- To view, visit http://gerrit.cloudera.org:8080/9863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie68e143c3c317c7690af097e6485934feb1010b4 Gerrit-Change-Number: 9863 Gerrit-PatchSet: 7 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 03 Apr 2018 18:01:01 +0000 Gerrit-HasComments: Yes
