Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9948 )
Change subject: Add GetFlags endpoint and tool ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9948/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9948/2//COMMIT_MSG@12 PS2, Line 12: It : supports returning all flags, and also filtering flags by tags. How difficult would it be to also filter by name via regex or something? Do you think that would that be useful? Stability, default values, and (less frequently) names change from version to version so I'd imagine the more filtering power the better. That said it's probably not a pre-req to merging this patch. -- To view, visit http://gerrit.cloudera.org:8080/9948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia35b4261099c1a3c6e2ff68e907c84df9a7ff699 Gerrit-Change-Number: 9948 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Sat, 07 Apr 2018 17:53:30 +0000 Gerrit-HasComments: Yes
