Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10054 )
Change subject: [tools] minor enhancements on 'kudu cluster ksck' output ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10054/2/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10054/2/src/kudu/tools/ksck.cc@536 PS2, Line 536: "Total:\n tables $0\n tablets $1\n replicas $2" nit: I prefer to put output like this in a table, e.g. | Total ---------+------ Tables | 10 Tablets | 180 Replicas | 540 Btw did you know gerrit's comment editor doesn't use a fixed-width font, so it's obnoxious to get a table to line up like that :). http://gerrit.cloudera.org:8080/#/c/10054/2/src/kudu/tools/ksck.cc@870 PS2, Line 870: const int table_num_replicas = table->num_replicas(); nit: Eliminate the local in favor of ts->replication_factor -- To view, visit http://gerrit.cloudera.org:8080/10054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0888ef640b215e1e0cf1f872f02cfe34f4ef5ba6 Gerrit-Change-Number: 10054 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Thu, 12 Apr 2018 23:52:50 +0000 Gerrit-HasComments: Yes
