Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4425 )
Change subject: WIP: java: enable error-prone for java builds ...................................................................... Patch Set 3: (3 comments) How does error-prone compare to findbugs/spotbugs? http://gerrit.cloudera.org:8080/#/c/4425/3/java/build.gradle File java/build.gradle: http://gerrit.cloudera.org:8080/#/c/4425/3/java/build.gradle@24 PS3, Line 24: id 'net.ltgt.errorprone' version '0.0.13' apply false I have been putting all of these static analysis checks into quality.gradle http://gerrit.cloudera.org:8080/#/c/4425/3/java/build.gradle@48 PS3, Line 48: apply plugin: 'java' Any reason you changed this to single quotes? http://gerrit.cloudera.org:8080/#/c/4425/3/java/build.gradle@51 PS3, Line 51: apply from: "$rootDir/gradle/errorprone.gradle" Did you add this file? I have been putting all of these static analysis checks into quality.gradle -- To view, visit http://gerrit.cloudera.org:8080/4425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebafbb307904875490426dd699ab1f55e21d284d Gerrit-Change-Number: 4425 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 25 Apr 2018 01:31:18 +0000 Gerrit-HasComments: Yes
