David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10072 )
Change subject: KUDU-2399: Support IS NULL / IS NOT NULL predicates in Python ...................................................................... Patch Set 4: (1 comment) thanks for the explanation, sorry for the delay. I agree that this makes more sense. Ok by me after the nit is fixed http://gerrit.cloudera.org:8080/#/c/10072/4/python/kudu/tests/test_scanner.py File python/kudu/tests/test_scanner.py: http://gerrit.cloudera.org:8080/#/c/10072/4/python/kudu/tests/test_scanner.py@75 PS4, Line 75: scanner.set_projected_column_indexes([0, 2]) > This test was already broken as the title says it was supposed to test a pr I'm ok either way just wanted the explanation, up to you -- To view, visit http://gerrit.cloudera.org:8080/10072 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52a22d6d8a8fe9a6049270596eb131799c37f82f Gerrit-Change-Number: 10072 Gerrit-PatchSet: 4 Gerrit-Owner: a...@phdata.io Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: a...@phdata.io Gerrit-Comment-Date: Thu, 26 Apr 2018 22:54:16 +0000 Gerrit-HasComments: Yes
