Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10377 )
Change subject: catalog-manager: return error from FindAndLockTable if table not found ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10377/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/10377/1/src/kudu/master/catalog_manager.cc@1679 PS1, Line 1679: return Status::InvalidArgument("Missing Table ID or Table Name"); > This is handled in MasterServiceImpl by calls to CheckRespErrorOrSetUnknown Oh, I see. Yeah, I think it's still worth setting up the response fields explicitly here just so FindAndLockTable has consistent behavior regardless of the error it produces. -- To view, visit http://gerrit.cloudera.org:8080/10377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d8176d6886474a84b4c75c80f50763eabe70a6d Gerrit-Change-Number: 10377 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 14 May 2018 17:48:56 +0000 Gerrit-HasComments: Yes
