Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10422 )
Change subject: [webui] Convert /tablets page to mustache ...................................................................... Patch Set 1: (3 comments) Hm.. To Alexey's point, maybe we should meet in the middle with "tablet replicas" or something? I don't have a strong opinion either way. http://gerrit.cloudera.org:8080/#/c/10422/1/src/kudu/tserver/tserver_path_handlers.cc File src/kudu/tserver/tserver_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/10422/1/src/kudu/tserver/tserver_path_handlers.cc@237 PS1, Line 237: auto make_replicas_json = [this Might be missing something, but why does `this` need to be here? Also can this be const auto? http://gerrit.cloudera.org:8080/#/c/10422/1/src/kudu/tserver/tserver_path_handlers.cc@259 PS1, Line 259: replica->tablet() != nullptr) { : replica_json["id_or_link"] = TabletLink(status.tablet_id()); : } else { : replica_json["id_or_link"] = status.tablet_id(); : } : replica_json["partition"] = : replica->tablet_metadata() : ->partition_schema() : .PartitionDebugString(replica->tablet_metadata()->partition(), : replica->tablet_metadata()->schema()); : replica_json["state"] = replica->HumanReadableState(); : if (replica->tablet() != nullptr) { : replica_json["mem_bytes"] = HumanReadableNumBytes::ToString( : replica->tablet()->mem_tracker()->consumption()); nit: maybe pull out `replica->tablet()` and `replica->tablet_metadata()` into their own local variables? Also we should be able to merge L270 and L259, no? http://gerrit.cloudera.org:8080/#/c/10422/1/www/tablets.mustache File www/tablets.mustache: http://gerrit.cloudera.org:8080/#/c/10422/1/www/tablets.mustache@96 PS1, Line 96: <th>Write buffer memory usage</th> : <th>On-disk size</th> Are these expected for tombstones? Everything else I can see being useful, if anything for tombstoned voting, but IIUC these should both be 0, right? -- To view, visit http://gerrit.cloudera.org:8080/10422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifddd74b23add52ae181b98a226b39e39df9b51ce Gerrit-Change-Number: 10422 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 17 May 2018 17:57:41 +0000 Gerrit-HasComments: Yes
