Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10422 )
Change subject: [webui] Convert /tablets page to mustache ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10422/4/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/10422/4/src/kudu/tserver/tablet_server-test.cc@403 PS4, Line 403: ASSERT_STR_CONTAINS(buf.ToString(), "RANGE (key) PARTITION UNBOUNDED"); : : // Tablet page should include the schema. : ASSERT_OK(c.FetchURL(Substitute("http://$0/tablet?id=$1";, addr, kTabletId), : &buf)); : ASSERT_STR_CONTAINS(buf.ToString(), "key"); : ASSERT_STR_CONTAINS(buf.ToString(), "string NULLABLE"); > I'm surprised these had to be changed. Was it caused by some spacing issue The original asserts had html bits in them. Without a template to fill in, the jenkins Kudu processes just return the json body, so there were no html tags. -- To view, visit http://gerrit.cloudera.org:8080/10422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifddd74b23add52ae181b98a226b39e39df9b51ce Gerrit-Change-Number: 10422 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Sun, 20 May 2018 18:01:23 +0000 Gerrit-HasComments: Yes
