Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10399 )
Change subject: [tools] rebalancer in the kudu CLI tool ...................................................................... Patch Set 23: (5 comments) http://gerrit.cloudera.org:8080/#/c/10399/23/src/kudu/tools/rebalancer.cc File src/kudu/tools/rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/10399/23/src/kudu/tools/rebalancer.cc@127 PS23, Line 127: ave > nit: avg Done http://gerrit.cloudera.org:8080/#/c/10399/23/src/kudu/tools/rebalancer.cc@170 PS23, Line 170: ave > nit: avg Done http://gerrit.cloudera.org:8080/#/c/10399/23/src/kudu/tools/tool_replica_util.h File src/kudu/tools/tool_replica_util.h: http://gerrit.cloudera.org:8080/#/c/10399/23/src/kudu/tools/tool_replica_util.h@84 PS23, Line 84: // The > nit: funny line wrap. Done http://gerrit.cloudera.org:8080/#/c/10399/23/src/kudu/tools/tool_replica_util.cc File src/kudu/tools/tool_replica_util.cc: http://gerrit.cloudera.org:8080/#/c/10399/23/src/kudu/tools/tool_replica_util.cc@195 PS23, Line 195: IsMoveComplete > There's one funny thing about this function, which is that in 3-4-3 mode it Indeed. I renamed this function into CheckCompleteMove() and added corresponding comment. http://gerrit.cloudera.org:8080/#/c/10399/23/src/kudu/tools/tool_replica_util.cc@360 PS23, Line 360: > nit: extra space. Done -- To view, visit http://gerrit.cloudera.org:8080/10399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I269ea1dcb0b528ad9f03308bac6b8769e2141238 Gerrit-Change-Number: 10399 Gerrit-PatchSet: 23 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Thu, 07 Jun 2018 21:11:51 +0000 Gerrit-HasComments: Yes
