Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10652 )
Change subject: Log idle time when expiring tablet copy sessions ...................................................................... Log idle time when expiring tablet copy sessions It would aid debugging to print the session idle time when logging that tablet copy sessions have expired and are being killed. Tested this by running TabletCopyServiceTest.TestSessionTimeout and observing the output in the logs, which looked like this: I0607 23:44:18.084945 31632 tablet_copy_service.cc:434] P 446ddba1bf9f43089120e9fa6810c5b5: tablet copy session 446ddba1bf9f43089120e9fa6810c5b5-TestTablet on tablet TestTablet with peer 446ddba1bf9f43089120e9fa6810c5b5 has expired after 4.007s of idle time I0607 23:44:18.085067 31632 tablet_copy_service.cc:413] P 446ddba1bf9f43089120e9fa6810c5b5: ending tablet copy session 446ddba1bf9f43089120e9fa6810c5b5-TestTablet on tablet TestTablet with peer 446ddba1bf9f43089120e9fa6810c5b5 Note that it expired after 4 seconds of idle time because I temporarily modified the test to expire after 4 seconds instead of 0 seconds, which is the value it normally uses to obtain a fast test run. Change-Id: I3dd37afbe6faeb29d05aafd799bc05ed2b2af4d6 Reviewed-on: http://gerrit.cloudera.org:8080/10652 Tested-by: Kudu Jenkins Reviewed-by: Will Berkeley <[email protected]> --- M src/kudu/tserver/tablet_copy_service.cc M src/kudu/tserver/tablet_copy_service.h M src/kudu/tserver/tablet_copy_source_session.h 3 files changed, 28 insertions(+), 16 deletions(-) Approvals: Kudu Jenkins: Verified Will Berkeley: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/10652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3dd37afbe6faeb29d05aafd799bc05ed2b2af4d6 Gerrit-Change-Number: 10652 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]>
