Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10653 )
Change subject: Add scan request timeout to Kudu scan token API ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10653/3/src/kudu/client/client.proto File src/kudu/client/client.proto: http://gerrit.cloudera.org:8080/#/c/10653/3/src/kudu/client/client.proto@108 PS3, Line 108: fixed64 > I'd use a normal int64 here. I think the fixed types are used above becaus Ah, makes sense. Done. http://gerrit.cloudera.org:8080/#/c/10653/3/src/kudu/client/scan_token-test.cc File src/kudu/client/scan_token-test.cc: http://gerrit.cloudera.org:8080/#/c/10653/3/src/kudu/client/scan_token-test.cc@307 PS3, Line 307: ASSERT_GT(tokens.size(), 0); > Also checked on line 317 Done -- To view, visit http://gerrit.cloudera.org:8080/10653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I151cd1da27419361f507e9ad29276c2b50153077 Gerrit-Change-Number: 10653 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 15 Jun 2018 01:37:38 +0000 Gerrit-HasComments: Yes
