Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10777 )
Change subject: KUDU-2260: Log block manager should handle null bytes in metadata on crash ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10777/2/src/kudu/util/pb_util.cc File src/kudu/util/pb_util.cc: http://gerrit.cloudera.org:8080/#/c/10777/2/src/kudu/util/pb_util.cc@318 PS2, Line 318: // This can happen e.g. on ext4 in the default data=ordered mode, when the : // filesize metadata is updated but the new data is not persisted. how does this happen, though? data=ordered is supposed to be: data=ordered (*) All data are forced directly out to the main file system prior to its metadata being committed to the journal. that's the bit I never understood about this bug. http://gerrit.cloudera.org:8080/#/c/10777/2/src/kudu/util/slice.h File src/kudu/util/slice.h: http://gerrit.cloudera.org:8080/#/c/10777/2/src/kudu/util/slice.h@302 PS2, Line 302: ATTRIBUTE_NO_SANITIZE_THREAD is this attribute needed in the header? thought it would only get picked up on the declaration -- To view, visit http://gerrit.cloudera.org:8080/10777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0af5c9dbbe28afe7a179595ad20392b99cde2a1b Gerrit-Change-Number: 10777 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 21 Jun 2018 16:10:12 +0000 Gerrit-HasComments: Yes
