Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10729 )
Change subject: java: Move static helper functions out of BaseKuduTest ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java: http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@20 PS3, Line 20: import static org.apache.kudu.util.ClusterTestUtil.getSchemaWithAllTypes; Are these needed? http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@125 PS3, Line 125: protected static KuduTable createFourTabletsTableWithNineRows(String tableName) throws Can this very specific method be moved too? Maybe to some util in the kudu-client-tools test directory? http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/util/ClusterTestUtil.java File java/kudu-client/src/test/java/org/apache/kudu/util/ClusterTestUtil.java: http://gerrit.cloudera.org:8080/#/c/10729/3/java/kudu-client/src/test/java/org/apache/kudu/util/ClusterTestUtil.java@31 PS3, Line 31: public abstract class ClusterTestUtil { Perhaps ClientTestUtil since it's not really testing a cluster but testing the client functionality (single node or not). -- To view, visit http://gerrit.cloudera.org:8080/10729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1466dcc0fc86897b504c154053c8f7e76f33c92c Gerrit-Change-Number: 10729 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 25 Jun 2018 15:36:04 +0000 Gerrit-HasComments: Yes
