Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10217 )
Change subject: KUDU-2191: HMS Metadata Consistency Check Tool ...................................................................... Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/10217/13/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10217/13/src/kudu/tools/tool_action_hms.cc@343 PS13, Line 343: std::vector<Status> error_messages; These don't appear to be printed to the console. http://gerrit.cloudera.org:8080/#/c/10217/13/src/kudu/tools/tool_action_hms.cc@372 PS13, Line 372: LOG(WARNING) << Substitute("Found legacy table $0.$1 in the Hive Metastore, " Perhaps the tool could output a table for legacy tables, and if there are any then you could additionally print this hint to use the upgrade tool once. http://gerrit.cloudera.org:8080/#/c/10217/13/src/kudu/tools/tool_action_hms.cc@375 PS13, Line 375: error_messages.push_back(Status::IllegalState("Legacy table found")); Is it meant that this exact same status will get added multiple times? -- To view, visit http://gerrit.cloudera.org:8080/10217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3495e9c755571b85beaecca849f83457b592ee90 Gerrit-Change-Number: 10217 Gerrit-PatchSet: 13 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Mon, 25 Jun 2018 21:43:36 +0000 Gerrit-HasComments: Yes
