Andrew Wong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10693 )

Change subject: parse_metrics_log: update to the new format
......................................................................

parse_metrics_log: update to the new format

The new diagnostics logs report more than just metrics, and thus, output
a bit differently than they did in simpler times. This patch updates the
parsing to be compatible with the new logs.

The changes this patch addresses:
- each metrics log line had a different number of fields
- the metrics log will only emit metrics from entities that have
  changed; as such, the processing of metrics has been changed; where we
  previously filled in NaNs for missing data, we now pull from the
  previous snapshot, or fill in 0 if one doesn't exist

I tested this manually by running against some metrics logs I collected
across a couple of workloads. The results seem to match what was
expected.

Change-Id: If11b7ecc93a3f64db3b7c1994f47308b3ec44029
Reviewed-on: http://gerrit.cloudera.org:8080/10693
Reviewed-by: Todd Lipcon <t...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/scripts/parse_metrics_log.py
1 file changed, 124 insertions(+), 67 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If11b7ecc93a3f64db3b7c1994f47308b3ec44029
Gerrit-Change-Number: 10693
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to