Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10817 )
Change subject: WIP: KUDU-2191: support table-name identifiers with upper case chars ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/10817/3/src/kudu/hms/hms_catalog.h File src/kudu/hms/hms_catalog.h: http://gerrit.cloudera.org:8080/#/c/10817/3/src/kudu/hms/hms_catalog.h@162 PS3, Line 162: // Parses a Kudu table name into a Hive database and table name. > > I think StringPiece is a more idiomatic choice for "pointer to part of a But why is it important for NormalizeTableName to mutate in place? http://gerrit.cloudera.org:8080/#/c/10817/5/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/10817/5/src/kudu/master/catalog_manager.cc@4796 PS5, Line 4796: In this case the table is guaranteed to be a legacy table which : // has survived since before the cluster was configured to integrate with : // the HMS. That's not true across the board though; NormalizeTableName is used to normalize the name of a new table in CreateTable. Shouldn't we preserve the error in that case? http://gerrit.cloudera.org:8080/#/c/10817/5/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/10817/5/src/kudu/mini-cluster/external_mini_cluster.cc@264 PS5, Line 264: void ExternalMiniCluster::DisableMetastoreIntegration() { Shouldn't this enforce that the cluster is shut down? The enforcement in SetDaemonBinPath is in the SetExePath calls. -- To view, visit http://gerrit.cloudera.org:8080/10817 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18977d6fe7b2999a36681a728ac0d1e54b7f38cd Gerrit-Change-Number: 10817 Gerrit-PatchSet: 5 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 28 Jun 2018 00:28:37 +0000 Gerrit-HasComments: Yes
