Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10725 )
Change subject: spark: Add support for scanRequestTimeout to DefaultSource ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/10725/8/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: http://gerrit.cloudera.org:8080/#/c/10725/8/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala@24 PS8, Line 24: import com.google.common.annotations.VisibleForTesting guava isn't a dependency of kudu-spark, so this could be problematic. It's also arguably not needed, since the symbol you are exposing isn't actually public, it's only visible within this project. -- To view, visit http://gerrit.cloudera.org:8080/10725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62b01af9d0532448fc3a6cf9328b3912a7865ebb Gerrit-Change-Number: 10725 Gerrit-PatchSet: 8 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 11 Jul 2018 18:53:38 +0000 Gerrit-HasComments: Yes
