Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10915 )
Change subject: rpcz: print timeout units (ms) when logging ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10915/1/src/kudu/rpc/rpcz_store.cc File src/kudu/rpc/rpcz_store.cc: http://gerrit.cloudera.org:8080/#/c/10915/1/src/kudu/rpc/rpcz_store.cc@252 PS1, Line 252: << call->header_.timeout_millis() << "ms)."; > if so it would be nice to actually print it twice, like 12532ms (12.5sec) o Good suggestions, will do. -- To view, visit http://gerrit.cloudera.org:8080/10915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I043d25b83cb4d2470cf0d9d3945e8ace633d9a5a Gerrit-Change-Number: 10915 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 11 Jul 2018 19:15:18 +0000 Gerrit-HasComments: Yes
