Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10929 )
Change subject: memrowset: support iteration with omit_deleted_rows=false ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10929/2/src/kudu/tablet/memrowset.h File src/kudu/tablet/memrowset.h: http://gerrit.cloudera.org:8080/#/c/10929/2/src/kudu/tablet/memrowset.h@562 PS2, Line 562: should_be_excluded > how about should_be_included? Made the change, though not sure if it's any more or less clear. -- To view, visit http://gerrit.cloudera.org:8080/10929 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie018043518b437ecc719cf9f87b2c5eea560c9a1 Gerrit-Change-Number: 10929 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 19 Jul 2018 18:52:47 +0000 Gerrit-HasComments: Yes
