Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11030 )
Change subject: Scala code formatting with Scalafmt ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11030/2/java/kudu-backup/out/test/resources/log4j.properties File java/kudu-backup/out/test/resources/log4j.properties: http://gerrit.cloudera.org:8080/#/c/11030/2/java/kudu-backup/out/test/resources/log4j.properties@1 PS2, Line 1: # Licensed to the Apache Software Foundation (ASF) under one > Should we add the out directory to Kudu's .gitignore? i.e. There us a .gitignore file at the java directory level we could use to ignore /out. But because this is an old bug and it's environmental, I am not sure it's worth having in the project. -- To view, visit http://gerrit.cloudera.org:8080/11030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac96383d88394084e19712177d05f9fc63de766c Gerrit-Change-Number: 11030 Gerrit-PatchSet: 2 Gerrit-Owner: Tony Foerster <anthonymfoers...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Tue, 24 Jul 2018 17:03:33 +0000 Gerrit-HasComments: Yes
