Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11032 )
Change subject: [tablet] clean-up on replay of WAL entries ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11032/1/src/kudu/consensus/log_util.h File src/kudu/consensus/log_util.h: http://gerrit.cloudera.org:8080/#/c/11032/1/src/kudu/consensus/log_util.h@208 PS1, Line 208: Status ReadEntries(std::vector<std::unique_ptr<LogEntryPB>>* entries); You could use LogEntries here too, if you're willing to define it outside of log-test-base.h. http://gerrit.cloudera.org:8080/#/c/11032/1/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: http://gerrit.cloudera.org:8080/#/c/11032/1/src/kudu/tablet/tablet_bootstrap.cc@473 PS1, Line 473: //string debug_str = entry ? SecureShortDebugString(*entry) : ""; Remove this? -- To view, visit http://gerrit.cloudera.org:8080/11032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie39516b09e4c756e8af1d8e1a5604672c96a80cb Gerrit-Change-Number: 11032 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 24 Jul 2018 18:15:11 +0000 Gerrit-HasComments: Yes