Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10926 )
Change subject: memrowset: support iteration with snap_to_exclude ...................................................................... memrowset: support iteration with snap_to_exclude Following on the commit that introduced the snap_to_exclude iterator option, this commit modifies the MemRowSet iterator to take snap_to_exclude into consideration (if it is set) when determining which rows and mutations are relevant to an iterator. I've also pulled the "exceeded the iterator's scan bounds" short-circuit out of the MVCC checks. If it were true for a row excluded by MVCC, it'd be true for all subsequent rows too. Change-Id: I9be2ab5af4d5223889e4545ae1db7cc0275480ce Reviewed-on: http://gerrit.cloudera.org:8080/10926 Reviewed-by: Todd Lipcon <t...@apache.org> Tested-by: Kudu Jenkins Reviewed-by: Mike Percy <mpe...@apache.org> --- M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/memrowset.cc M src/kudu/tablet/memrowset.h M src/kudu/tablet/tablet-test-util.h 5 files changed, 173 insertions(+), 40 deletions(-) Approvals: Todd Lipcon: Looks good to me, but someone else must approve Kudu Jenkins: Verified Mike Percy: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/10926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9be2ab5af4d5223889e4545ae1db7cc0275480ce Gerrit-Change-Number: 10926 Gerrit-PatchSet: 9 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
