Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11059 )
Change subject: Add kudu-backup module to Maven build ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11059/3/java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala File java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala: http://gerrit.cloudera.org:8080/#/c/11059/3/java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala@226 PS3, Line 226: Bytes.getString(Base64.decodeBase64(value.asInstanceOf[Array[Byte]])) I think this should be `Base64.encodeBase64String(value.asInstanceOf[Array[Byte]])` http://gerrit.cloudera.org:8080/#/c/11059/3/java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala@243 PS3, Line 243: case Type.BINARY => Base64.encodeBase64(value.asInstanceOf[Array[Byte]]) I think this should be `Base64.decodeBase64(value)` -- To view, visit http://gerrit.cloudera.org:8080/11059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1b34b733d8d85106060068e611be7eecc0717f2 Gerrit-Change-Number: 11059 Gerrit-PatchSet: 3 Gerrit-Owner: Tony Foerster <anthonymfoers...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tony Foerster <anthonymfoers...@gmail.com> Gerrit-Comment-Date: Thu, 26 Jul 2018 19:15:57 +0000 Gerrit-HasComments: Yes
