Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11089 )
Change subject: [Java] Minor fixes to the Scalafmt changes ...................................................................... Patch Set 2: (2 comments) LGTM, just a couple small questions http://gerrit.cloudera.org:8080/#/c/11089/2/java/.scalafmt.conf File java/.scalafmt.conf: http://gerrit.cloudera.org:8080/#/c/11089/2/java/.scalafmt.conf@10 PS2, Line 10: 80 Why not 100 cols like the rest of the Kudu code base? per https://kudu.apache.org/docs/contributing.html#_line_length http://gerrit.cloudera.org:8080/#/c/11089/2/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/11089/2/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@149 PS2, Line 149: Objects.equal(before.getType, after.getType) && Why not indent this? -- To view, visit http://gerrit.cloudera.org:8080/11089 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied557d2ab501f43288e7edae2874ba123ab036bc Gerrit-Change-Number: 11089 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tony Foerster <anthonymfoers...@gmail.com> Gerrit-Comment-Date: Tue, 31 Jul 2018 20:51:48 +0000 Gerrit-HasComments: Yes
