Hello Thomas Marshall, Jean-Daniel Cryans, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10656
to look at the new patch set (#12).
Change subject: KUDU-2459: add placeholder names to some CREATE TABLE statements
......................................................................
KUDU-2459: add placeholder names to some CREATE TABLE statements
Under the Tables section of Kudu Web UI, for a selected table, the table
metrics display a CREATE TABLE statement that can be run to make Impala
cognizant of that table. However, in generation of this statement, the
table name tries to match the original Kudu tablename which may not
always be acceptable as a tablename for Impala. For example, Kudu
accepts dot in tablename, Impala does not. The CREATE TABLE statement
thus throws an invalid tablename error in Impala.
We considered trying to drive an Impala-conforming name from the Kudu-
supplied tablename but that could result in surprising/unintuitive
results.We also want to leverage the current functionality of auto-
generated statement where the name is valid. Therefore with this update,
invalid tablenames have been identified and updated by a placeholder
tablename for end user to replace with a valid tablename. The rules to
check Impala conformity are below --
- The minimum length of an identifier is 1 character.
- The maximum length of an identifier is currently 128 characters.
- An identifier must start with an alphabetic character.
The remainder can contain any combination of alphanumeric characters and
underscores. Quoting the identifier with backticks has no effect on the
allowed characters in the name.
- An identifier can contain only ASCII characters.
Change-Id: If9e5242318589452a0507d3973b9be3e6a186a69
---
M src/kudu/master/master_path_handlers.cc
M www/table.mustache
2 files changed, 24 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/10656/12
--
To view, visit http://gerrit.cloudera.org:8080/10656
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9e5242318589452a0507d3973b9be3e6a186a69
Gerrit-Change-Number: 10656
Gerrit-PatchSet: 12
Gerrit-Owner: Shriya Gupta <shriya...@gmail.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Shriya Gupta <shriya...@gmail.com>
Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu>
