Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11262 )
Change subject: [gradle] fetch gradle-wrapper.jar from raw.githubusercontent.com ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11262/1/java/gradle/wrapper.gradle File java/gradle/wrapper.gradle: http://gerrit.cloudera.org:8080/#/c/11262/1/java/gradle/wrapper.gradle@66 PS1, Line 66: if ! curl -s -S --retry 3 -L -o "$wrapperJarPath" "$wrapperJarUrl"; then > If you want to keep those line breaks they need to be added here. It seems here the line is not that long (and this is the source file). So, I think it's OK to have it as is -- I don't think we need to care about line length in the generated files. -- To view, visit http://gerrit.cloudera.org:8080/11262 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia745ef4d69726852fbe60be0d1778705d5580f14 Gerrit-Change-Number: 11262 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 17 Aug 2018 20:44:31 +0000 Gerrit-HasComments: Yes