Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11260 )
Change subject: KUDU-2531: (part 2) Add -nobackup flag to pbc edit tool ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11260/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/11260/1/src/kudu/tools/kudu-tool-test.cc@845 PS1, Line 845: return RunTool(Substitute("pbc edit --nobackup $0/instance", kTestDir), Could you actually verify that --nobackup generates no backup file, while --backup (the default) does? You could probably do it roughly via Env::GetChildren and counting the number of files. -- To view, visit http://gerrit.cloudera.org:8080/11260 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If544f7682a30933077db0824452639a68507ba40 Gerrit-Change-Number: 11260 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 17 Aug 2018 21:03:39 +0000 Gerrit-HasComments: Yes