Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11259 )
Change subject: KUDU-2531: (part 1) Ignore backup files ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11259/1/src/kudu/util/env_util.cc File src/kudu/util/env_util.cc: http://gerrit.cloudera.org:8080/#/c/11259/1/src/kudu/util/env_util.cc@312 PS1, Line 312: iter->find(kTmpInfix) != string::npos || : iter->find(kBakInfix) != string::npos) { > Both of these exceptions feel really strange to me. These are real files; w It's a good question. I followed the places kTmpInfix was ignored assuming backup files would want to be too. It looks like this was moved from ExternalMiniClusterFsInspector at one point: https://github.com/apache/kudu/commit/42711bac4017b3ad11ce4d20ff9e61b6eb0d69f9 The commit that added the tmp filtering is here: https://github.com/apache/kudu/commit/8186cc18db6f2879e6148ab1eff3a30f272e3e83 Even now it looks like that call is only used in tests. It looks like I could safely leave this out from there if you like. I can doc that .tmp files are ignored too. -- To view, visit http://gerrit.cloudera.org:8080/11259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9f0e6dd8925519aa3ed3e735f2987743f2ef1d1 Gerrit-Change-Number: 11259 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 17 Aug 2018 21:30:08 +0000 Gerrit-HasComments: Yes
