Hello Mike Percy, Grant Henke, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11267
to review the following change.
Change subject: common: add equality methods to ColumnBlock and SelectionVector
......................................................................
common: add equality methods to ColumnBlock and SelectionVector
These are useful in tests.
I also snuck in a change to ScopedColumnBlock that should simplify tests:
all rows begin nulled out. This means two freshly created ScopedColumnBlocks
are equal as per ColumnBlock::Equals; previously the garbage data in data_
and null_bitmap_ virtually guaranteed inequality.
Change-Id: I9712bd7748bb01af7b6f68897a453a0aa149cdcf
---
M src/kudu/common/CMakeLists.txt
A src/kudu/common/columnblock-test.cc
M src/kudu/common/columnblock.h
A src/kudu/common/rowblock-test.cc
M src/kudu/common/rowblock.cc
M src/kudu/common/rowblock.h
6 files changed, 149 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/11267/1
--
To view, visit http://gerrit.cloudera.org:8080/11267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9712bd7748bb01af7b6f68897a453a0aa149cdcf
Gerrit-Change-Number: 11267
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
