Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11311 )
Change subject: [cmake] add OpenSSL include path into -isystem ...................................................................... [cmake] add OpenSSL include path into -isystem Prior to this change, when OpenSSL package is installed under the same prefix as boost package (e.g. /opt/local on OS X if using MacPorts), running cmake will choose the thirdparty-built boost, but due to the intermix of '-isystem' and '-I' options, the '-I' path wins when running the compiler. I.e., the path specified with the '-I' option is chosen over the path specified with the '-isystem' option if the latter comes first in the command line. That could lead to mysterious compilation errors if the version and features of the OS-packaged boost library differ from those compiled under $KUDU_HOME/thirdparty. This patch puts the OpenSSL's include path into the -isystem category along with other third-party libraries used by Kudu. Aside from resolving the inconsistency mentioned above, this makes the usage of the angle brackets vs quotes in #include statement to be in sync with the way how OpenSSL headers are included into the Kudu source files. Change-Id: I345bf5f72fb9c899340339452ba1464becd6ada3 Reviewed-on: http://gerrit.cloudera.org:8080/11311 Reviewed-by: Adar Dembo <a...@cloudera.com> Tested-by: Alexey Serbin <aser...@cloudera.com> --- M CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Adar Dembo: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/11311 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I345bf5f72fb9c899340339452ba1464becd6ada3 Gerrit-Change-Number: 11311 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
