Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11176 )
Change subject: [build] Move default sanitizer options into build from shell scripts ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/11176/10/src/kudu/util/sanitizer_options.cc File src/kudu/util/sanitizer_options.cc: http://gerrit.cloudera.org:8080/#/c/11176/10/src/kudu/util/sanitizer_options.cc@35 PS10, Line 35: // A macro to turn a symbol into a string. : #define AS_STRING(x) AS_STRING_INTERNAL(x) : #define AS_STRING_INTERNAL(x) #x > Given this is all I use I preferred not to link in gutil. I will just link this. http://gerrit.cloudera.org:8080/#/c/11176/10/src/kudu/util/sanitizer_options.cc@42 PS10, Line 42: #if defined(KUDU_EXTERNAL_SYMBOLIZER_PATH) > I liked the idea of defining this in the same location as all the other san I will move it. -- To view, visit http://gerrit.cloudera.org:8080/11176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9eab2d3ef0b107ae9a4e971bf8a6514bf425f645 Gerrit-Change-Number: 11176 Gerrit-PatchSet: 10 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 24 Aug 2018 17:47:44 +0000 Gerrit-HasComments: Yes