Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11266 )
Change subject: bitmap: add equality method ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/11266/3/src/kudu/util/bitmap.h File src/kudu/util/bitmap.h: http://gerrit.cloudera.org:8080/#/c/11266/3/src/kudu/util/bitmap.h@118 PS3, Line 118: size_t uint8_t? http://gerrit.cloudera.org:8080/#/c/11266/3/src/kudu/util/bitmap.h@119 PS3, Line 119: return (bm1[num_full_bytes] & mask) == (bm2[num_full_bytes] & mask); nit: no need for the parens, can just write: return bm1[num_full_bytes] & mask == bm2[num_full_bytes] & mask; -- To view, visit http://gerrit.cloudera.org:8080/11266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If53e41250435501e158bdbc076dc8e89ea153256 Gerrit-Change-Number: 11266 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 27 Aug 2018 18:14:44 +0000 Gerrit-HasComments: Yes
