Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11340 )
Change subject: [build] add -DLEAK_SANITIZER to compilation flags ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11340/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/11340/1/CMakeLists.txt@353 PS1, Line 353: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=undefined,integer") Do you mind adding -DUNDEFINED_SANITIZER here? It's not causing problems now because we don't use suppressions, but it could in the future. I can also do it in a separate patch if you like. -- To view, visit http://gerrit.cloudera.org:8080/11340 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8caeaa080b93f67768d3d2251c7a366390a48f9 Gerrit-Change-Number: 11340 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 28 Aug 2018 01:48:50 +0000 Gerrit-HasComments: Yes
