Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11292 )
Change subject: KUDU-428: Sentry integration scaffolding ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/11292/6/src/kudu/sentry/CMakeLists.txt File src/kudu/sentry/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/11292/6/src/kudu/sentry/CMakeLists.txt@17 PS6, Line 17: Nit: could you add ### headers for sentry_thrift and kudu_sentry? http://gerrit.cloudera.org:8080/#/c/11292/6/src/kudu/sentry/CMakeLists.txt@29 PS6, Line 29: sentry_thrift Sort order here. http://gerrit.cloudera.org:8080/#/c/11292/6/src/kudu/sentry/sentry_client-test.cc File src/kudu/sentry/sentry_client-test.cc: http://gerrit.cloudera.org:8080/#/c/11292/6/src/kudu/sentry/sentry_client-test.cc@33 PS6, Line 33: TEST_F(SentryClientTest, ItWorks) { : SentryClient client; : std::move(client); : } Nice. -- To view, visit http://gerrit.cloudera.org:8080/11292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11 Gerrit-Change-Number: 11292 Gerrit-PatchSet: 6 Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Tue, 28 Aug 2018 22:56:27 +0000 Gerrit-HasComments: Yes
