Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11354 )
Change subject: KUDU-2560: exported thirdparty library variants should use exported deps ...................................................................... Patch Set 1: Code-Review+1 Reading the commit msg, this change makes sense, but I'll defer to Alexey. I haven't written enough CMake to know if there are any gotchas to keep in mind. -- To view, visit http://gerrit.cloudera.org:8080/11354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28dd499b152d4eadd9b5cf6575650a1a3db163f1 Gerrit-Change-Number: 11354 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 29 Aug 2018 22:48:15 +0000 Gerrit-HasComments: No