Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11367
Change subject: Improve logging of maintenance ops ...................................................................... Improve logging of maintenance ops MRS flushes and rowset compactions ================================= MRS flush and rowset compaction logging now includes the number of new rowsets flushed. Before: I0830 14:54:24.353442 2830984064 tablet.cc:1651] T test_tablet_id P 78c16245dcd84048bf66debf1958c169: Flush successful on 100 rows (9272 bytes) I0830 14:58:23.309068 2830984064 tablet.cc:1651] T test_tablet_id P 15853c32ec1d4f70b82aef90da2108a6: Compaction successful on 30 rows (4957 bytes) After: I0830 14:54:24.353442 2830984064 tablet.cc:1651] T test_tablet_id P 78c16245dcd84048bf66debf1958c169: Flush successful on 100 rows (1 rowsets, 9272 bytes) I0830 14:58:23.309068 2830984064 tablet.cc:1651] T test_tablet_id P 15853c32ec1d4f70b82aef90da2108a6: Compaction successful on 30 rows (1 rowsets, 4957 bytes) Major delta compactions ======================= Major delta compaction had logging that was a little too verbose- for each delta store compacted, it printed out a separate log message with mutation counts. Instead, this patch makes the old more detailed output appear only when verbose logging is on and at INFO level substitutes a total count of each mutation type and a count of delta files compacted, as part of the "Finished" message. Before: I0830 15:09:31.731609 2830984064 delta_compaction.cc:296] Starting major delta compaction for columns val1[int32 NOT NULL] val3[int32 NOT NULL] val4[string NOT NULL] I0830 15:09:31.731645 2830984064 delta_compaction.cc:300] Preparing to major compact delta file: 0044448509586267 (ts range=[101, 150], delete_count=[0], reinsert_count=[0], update_counts_by_col_id=[11:50,13:50,14:50]) I0830 15:09:31.731672 2830984064 delta_compaction.cc:300] Preparing to major compact delta file: 0044448509586268 (ts range=[151, 200], delete_count=[0], reinsert_count=[0], update_counts_by_col_id=[11:50,13:50,14:50]) I0830 15:09:31.735069 2830984064 delta_compaction.cc:306] Finished major delta compaction of columns val1[int32 NOT NULL] val3[int32 NOT NULL] val4[string NOT NULL] After: I0830 14:45:38.433037 2830984064 delta_compaction.cc:326] Starting major delta compaction for columns val1[int32 NOT NULL], val3[int32 NOT NULL], val4[string NOT NULL] I0830 14:45:38.435420 2830984064 delta_compaction.cc:341] Finished major delta compaction of columns val1[int32 NOT NULL], val3[int32 NOT NULL], val4[string NOT NULL]. Compacted 1 delta files. Overall stats: delete_count=0, reinsert_count=0, update_count=150 Minor delta compactions and deltamemstore flushes already include good information on how much was compacted and flushed, respectively. Their logging is unchanged. Change-Id: I43883001c5a1c72ff1ca0c1bc84d24a8533e3891 --- M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/delta_stats.cc M src/kudu/tablet/delta_stats.h M src/kudu/tablet/delta_tracker.cc M src/kudu/tablet/diskrowset.h M src/kudu/tablet/tablet.cc 6 files changed, 64 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/11367/1 -- To view, visit http://gerrit.cloudera.org:8080/11367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I43883001c5a1c72ff1ca0c1bc84d24a8533e3891 Gerrit-Change-Number: 11367 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
