Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11377 )
Change subject: mini cluster: Add scripts to build binaries for testing use ...................................................................... Patch Set 1: (3 comments) Cool! Did you try to verify that binaries built on older OS X run on a newer one? http://gerrit.cloudera.org:8080/#/c/11377/1/build-support/build_mini_cluster_binaries.sh File build-support/build_mini_cluster_binaries.sh: http://gerrit.cloudera.org:8080/#/c/11377/1/build-support/build_mini_cluster_binaries.sh@46 PS1, Line 46: # TODO(mpercy): What's a better way to detect macOS? Another way of doing it is relying on $OSTYPE, like it's done in build-thirdparty.sh http://gerrit.cloudera.org:8080/#/c/11377/1/build-support/build_mini_cluster_binaries.sh@53 PS1, Line 53: /usr/local/opt/openssl That makes sense only in case of Homebrew, but it will not work in case of MacPorts or others. To make it generic, it possible to use pkg-config, and have a hard-coded path for Homebrew where pkg-config is broken. An example of how to do that is at: https://github.com/apache/kudu/blob/master/thirdparty/build-thirdparty.sh#L174 http://gerrit.cloudera.org:8080/#/c/11377/1/build-support/relocate_binaries_for_mini_cluster.py File build-support/relocate_binaries_for_mini_cluster.py: http://gerrit.cloudera.org:8080/#/c/11377/1/build-support/relocate_binaries_for_mini_cluster.py@284 PS1, Line 284: Kerberos|libSystem|libncurses What about libc++ and others? It's not excluded? -- To view, visit http://gerrit.cloudera.org:8080/11377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b8f90cfe80f6830177bf6ea9e0711eb0d034f75 Gerrit-Change-Number: 11377 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 03 Sep 2018 16:34:57 +0000 Gerrit-HasComments: Yes
