Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11263 )

Change subject: Blogpost describing index skip scan optimization.
......................................................................


Patch Set 5:

(4 comments)

Great progress!  Some more nits in addition to what Andrew already pointed at.

http://gerrit.cloudera.org:8080/#/c/11263/4/_posts/2018-08-17-index-skip-scan-optimization-in-kudu.md
File _posts/2018-08-17-index-skip-scan-optimization-in-kudu.md:

http://gerrit.cloudera.org:8080/#/c/11263/4/_posts/2018-08-17-index-skip-scan-optimization-in-kudu.md@73
PS4, Line 73:
            : Based on our experiments, on up to 10 million rows per tablet (as 
shown below), we found that the skip scan performa
> 1) Yes, these experiments were based on table schema and query pattern ment
I see.  Thank you for the information.


http://gerrit.cloudera.org:8080/#/c/11263/5/_posts/2018-08-17-index-skip-scan-optimization-in-kudu.md
File _posts/2018-08-17-index-skip-scan-optimization-in-kudu.md:

http://gerrit.cloudera.org:8080/#/c/11263/5/_posts/2018-08-17-index-skip-scan-optimization-in-kudu.md@9
PS5, Line 9: [index skip scan][1].
It's great that you found another reference to the same idea in the google's 
paper [2].  Do you think it's worth mentioning the other name for the 
technique?  Something like 'index skip scan (a.k.a. scan-to-seek, see section 
4.1 in [2]).


http://gerrit.cloudera.org:8080/#/c/11263/5/_posts/2018-08-17-index-skip-scan-optimization-in-kudu.md@104
PS5, Line 104: [1]
Do you feel good about adding one more reference?  I think 
https://www.sqlite.org/optoverview.html#skipscan is also a good one.  But it's 
up to you.


http://gerrit.cloudera.org:8080/#/c/11263/5/_posts/2018-08-17-index-skip-scan-optimization-in-kudu.md@105
PS5, Line 105: [2]:
nit: usually in the reference section they use '[x]' where it's possible to 
follow the link simply by clicking on it.  To enable those square brackets to 
appear in the rendered output, you need to duplicate them, e.g.

[[1]](https://my.url.io/) Mega-turbo resource

Or you want them to be just numbers followed by columns?



--
To view, visit http://gerrit.cloudera.org:8080/11263
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I2250652dcba3d1b0a06f1ffb7f23c11bf533d35e
Gerrit-Change-Number: 11263
Gerrit-PatchSet: 5
Gerrit-Owner: Anupama Gupta <ag3...@columbia.edu>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Anupama Gupta <ag3...@columbia.edu>
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Comment-Date: Tue, 04 Sep 2018 22:33:55 +0000
Gerrit-HasComments: Yes

Reply via email to