Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11389 )
Change subject: cfile-test: pass in IOContext on Open() ...................................................................... Patch Set 2: > > Patch Set 1: Code-Review+2 > > > > I'm curious why ASAN pre-commit build didn't catch that? > > Yeah, it's surprising that it passed entirely on CentOs 6.6. That > said, ASAN will cover: > - Use after free (dangling pointer dereference) > - Heap buffer overflow > - Stack buffer overflow > - Global buffer overflow > - Use after return > - Use after scope > - Initialization order bugs > - Memory leaks > > Of which this sort of error doesn't fall into any. It's certainly > similar, but not quite any of them. UBSAN would have probably > caught this though. Well, I meant ASAN build, but our ASAN build has both address and undefined sanitizers included. BTW, I'm not sure our ASAN configuration enables use-after-return and use-after-free traps. -- To view, visit http://gerrit.cloudera.org:8080/11389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaed883d26075ed1823882a7f7b18834f39b0732d Gerrit-Change-Number: 11389 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 05 Sep 2018 06:19:30 +0000 Gerrit-HasComments: No
