Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11197 )
Change subject: Add delete_external_catalogs flag to table delete tool ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/11197/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11197/5//COMMIT_MSG@7 PS5, Line 7: delete_external_catalogs modify_external_catalogs http://gerrit.cloudera.org:8080/#/c/11197/4/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/11197/4/src/kudu/client/client.h@1233 PS4, Line 1233: // Whether to apply the alteration to external catalogs, such as the Hive > Thanks a lot for bringing this up and I will take a note. I think this should be done as part of this patch, since the same lines of code are having to be churned anyway. http://gerrit.cloudera.org:8080/#/c/11197/5/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/11197/5/src/kudu/tools/tool_action_table.cc@43 PS5, Line 43: "when renaming a table."); 'renaming' -> 'renaming or dropping' -- To view, visit http://gerrit.cloudera.org:8080/11197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a128fb53c974a5c839786204d56408681b434e8 Gerrit-Change-Number: 11197 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 06 Sep 2018 22:58:56 +0000 Gerrit-HasComments: Yes
