Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11399 )
Change subject: build: add option to ignore test failures ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11399/1/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/11399/1/build-support/jenkins/build-and-test.sh@618 PS1, Line 618: if [ $TESTS_FAILED != 0 ] || [ $EXIT_STATUS != 0 ]; then You can combine this: if [ <expr1> -o <expr2> ]; then ... fi http://gerrit.cloudera.org:8080/#/c/11399/1/build-support/jenkins/build-and-test.sh@658 PS1, Line 658: if [ "$ERROR_ON_TEST_FAILURE" == "1" ] && [ "$TESTS_FAILED" == "1" ]; then And combine this too. http://gerrit.cloudera.org:8080/#/c/11399/1/build-support/jenkins/build-and-test.sh@659 PS1, Line 659: EXIT_STATUS=1 Should we avoid overwriting if EXIT_STATUS is non-zero? Is that even possible? -- To view, visit http://gerrit.cloudera.org:8080/11399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27ecacd499423755dbf742bb70db6a7f1e5c9db7 Gerrit-Change-Number: 11399 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 10 Sep 2018 20:12:41 +0000 Gerrit-HasComments: Yes
